morebits: batchOperation: minor improvements #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empty. When the pageList is empty, a quick abort results. Ideally, the postFinish() function should be executed even in this case.
siddharthvp
changed the title
siddharthvp
force-pushed
the
batchopfixes
branch
from
673c714
to
071013f
Compare
Amorymeltzer
reviewed
Jan 6, 2020
| ctx.running = false; | ||
| if (ctx.postFinish) { | ||
| ctx.postFinish(); |
There was a problem hiding this comment.
I think this is better than modifying fnDoneOne or something, if only for simplicity's sake, but even workerFailure calls fnDoneOne. It's a weird construct there overall.
Amorymeltzer
previously requested changes
Jan 6, 2020
If using mw.Api() (or anything other than Morebits.wiki.page/api) for processing pages in the worker, till now it was not possible to have invidual status lines for each page. This commit rectifies this deficiency by allowing a string input to workerSuccess() that would be treated as the page name, triggering individual status line generation. I've changed the condition `if (apiobj && apiobj.getStatusElement)` to `if (apiobj instanceof Morebits.wiki.page || apiobj instanceof Morebits.wiki.api)`. These are functionally same, but the latter is more explicit and clearer.
siddharthvp
force-pushed
the
batchopfixes
branch
from
071013f
to
9cf1877
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st commit: doc fixes.
2nd commit: execute
postFinish()even when thepageListis empty. This situation could occur when the pageList used is variable.3rd commit: allow individual status lines even if the
workerfunction is not usingMorebits.wiki.pageorMorebits.wiki.api.These will not have any effect on Twinkle.