New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speedy: Allow users to request salting #789
Conversation
Creation protection can be requested via checkbox. Not available when sysop is in sysop mode (though a future task could allow setting creation protection while deleting)
@siddharthvp @Amorymeltzer is this something that would need to be discussed onwiki first? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Busy but here's a quick pass on some things that stand out; I think this would be a welcome addition! I vaguely recall someone (Prax?) wanting this.
I think it'd be good to include this information in the CSD log as well, maybe either before or after the "additional information" bit.
Co-Authored-By: Amory Meltzer <Amorymeltzer@gmail.com>
Remove unneeded variable, move to above "Tag with multiple criteria"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and seems to work! I do think this will be well-received by many.
@DannyS712 I still think logging this request would be nice. I think doing (line 1667) something like:
if (params.requestsalt) {
appendText += '; requested [[WP:SALT|salting]]';
}
would do it. Maybe requested {{tl|salt}}ing
would be better, or some combination? I lean toward the policy.
One other consideration is the case of G10s. I believe that if G10 is provided in a tag, blanking the page, the {{salt}}
won't appear. I haven't seen this lately? Do folks put it on top of the g10 tag, or what? I can ask around.
When requesting salting, also log "; requested creation protection ([[WP:SALT|salting]])"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and seems to work! I do think this will be well-received by many.
@DannyS712 I still think logging this request would be nice. I think doing (line 1667) something like:
if (params.requestsalt) { appendText += '; requested [[WP:SALT|salting]]'; }would do it. Maybe
requested {{tl|salt}}ing
would be better, or some combination? I lean toward the policy.One other consideration is the case of G10s. I believe that if G10 is provided in a tag, blanking the page, the
{{salt}}
won't appear. I haven't seen this lately? Do folks put it on top of the g10 tag, or what? I can ask around.
{{done}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor improvement for g10s, otherwise LGTM! 👍
Per discussion, move salt tag above CSD tag on g10 tags Co-Authored-By: Amory Meltzer <Amorymeltzer@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!
Creation protection can be requested via checkbox. Not available when sysop is in sysop mode (though a future task could allow setting creation protection while deleting)