Hide space for portlet if unused

[DannyS712]

Closes #809

[Amorymeltzer]

@DannyS712 I asked this in #809, but is there a way to get a visual, on-screen change?

[DannyS712]

@DannyS712 I asked this in #809, but is there a way to get a visual, on-screen change?

What do you mean?

[Amorymeltzer]

I mean, it's clear that Twinkle is affecting the margin-right of Vector's p-cactions, but, as someone who doesn't regularly use Vector, what's a good way to visually notice this, like by having other gadgets enabled or something? Not, like, vital, but wondering for testing, etc.

[siddharthvp]

@DannyS712 I asked this in #809, but is there a way to get a visual, on-screen change?

Get yourself desysopped _{or use a non-admin account} and go to PrefixIndex in vector skin. There's an empty space next to the "More" button. Or am I misunderstanding your question?

[siddharthvp]

@Amorymeltzer raises a very valid point. Unsetting the CSS via JS causes the menu to jump, (which is ironically exactly what the css is supposed to prevent, though in the opposite way). We have to decide between which is a greater annoyance: an empty space where there should have the TW menu, or jumping back of the "More" to its original position?

At PrefixIndex, the jump isn't much of an issue as there's just the More button. But after #793, the issue could arise on other pages as well (Read, Edit, View history would all jump) for people who choose to disable several modules.

I wonder what @MusikAnimal thinks about this? He added the css originally.

[Amorymeltzer]

Yes that's the reason I ask. And yes, @siddharthvp, but I don't have any menu there in vector on my nonsysop account. What's in it? You two are obviously seeing something, but I've got a fairly clean/default gadget list for that account, so I'm assuming you both have put something in that menu that exposes the issue.

[siddharthvp]

I don't have any menu there in vector on my nonsysop account.

Oh yeah, those items in "More" are from userscripts. You should be able to get one by running mw.util.addPortletLink('p-cactions', '#', 'BAH');, or by installing some random script.

[Amorymeltzer]

As @siddharthvp noted and I suspected, this means a jump is back in play. I suppose it's better than an empty space?

[Amorymeltzer]

Circling back to this, what do folks think? I guess jumping is better than a lingering/ghost space?

[MusikAnimal]

In Twinkle, the only items that could show up at Special:PrefixIndex are for sysops, right? One possible solution would be to move the .client-js > body.skin-vector.mw-special-Prefixindex #p-cactions rule (and the other sysop-only rules, I guess) to a separate hidden peer gadget with rights=sysop in the definition.

At any rate, I can't imagine Special:PrefixIndex is super high-traffic, so it's not the end of the world to have empty space or jumping. If we have to chose between the two, I'd go with the latter. This is the way I always did it for MoreMenu, and I never received complaints. Remember, before the peer gadget stuff went live, everyone had jumping when the TW menu first loaded. So if 99% of the time you don't see jumping (the other 1% being at Special:PrefixIndex), that's still a win.

[Amorymeltzer]

Thanks MA — that's not a bad idea for the sysop-only bit, although as @Sd0001 points out it'll become more pronounced with #793. That roughly jives with what I figure, but then again I'm not on Vector so I really don't know how bad the jumping feels!

[Amorymeltzer]

Gonna edit to add a comment, but looks good!

[Amorymeltzer]

Done in 5cff2a8 (though I forgot to fix the typo)