Image: Don't assume a replacement was specified

[DannyS712]

Check for event.target.replacement as well.
Follow up #788
Closes #821

[Amorymeltzer]

Thank you for the contribution. It needed some fixes, so they were made in f1b0573. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.

[Amorymeltzer]

Thanks for the speedy catch here! 🚀 Will make live

[DannyS712]

@Amorymeltzer what if replacement exists but not replacement.value? Is it not better to explicitly check?

[Amorymeltzer]

Yeah, but I couldn't seem to trigger any errors? I was admittedly testing somewhat quickly, are you able to?

[DannyS712]

Just using the console:

var event = { target: { replacement: {} } }

event.target.replacement && event.target.replacement.value && event.target.replacement.value.trim()

event.target.replacement && event.target.replacement.value.trim()

First returns undefined, second is Uncaught TypeError: Cannot read property 'trim' of undefined at <anonymous>:1:60

Not sure if this could happen with the form, but just to be on the safe side...

[Amorymeltzer]

Yeah, couldn't trigger it from the form. I was surprised, tbh