xfd: Update technical RM hidden comment #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Onwiki comment updated in [1], per discussion at [2]; the current value results in the request being placed in the `Requests to revert undiscussed moves` section instead of the intended `Uncontroversial technical requests` section[3] [1] Diff: https://w.wiki/GtM [2] Discussion: https://w.wiki/GtN (permalink to current: https://w.wiki/GtP) [3] Diff: https://w.wiki/GtQ
|
Thanks @DannyS712 — this is getting annoying. I really don't want to leave a twinkle message, but if folks are gonna keep changing it (unlike every xfd...) then maybe we need to go for it. |
Amorymeltzer
approved these changes
Feb 10, 2020
Amorymeltzer
changed the title
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this pull request
Feb 14, 2020
… comment The hidden message has been changing frequently, leaving us behind (e.g. wikimedia-gadgets#791, wikimedia-gadgets#842), so by using a short regex rather than an exact string match, we should be able to handle subsequent changes. This change also only loads section number 2; possibly overkill, but could theoretically avoid some off-target effects with the page's other hidden comment.
wiki-ST47
pushed a commit
to wiki-ST47/twinkle
that referenced
this pull request
Sep 2, 2020
… comment The hidden message has been changing frequently, leaving us behind (e.g. wikimedia-gadgets#791, wikimedia-gadgets#842), so by using a short regex rather than an exact string match, we should be able to handle subsequent changes. This change also only loads section number 2; possibly overkill, but could theoretically avoid some off-target effects with the page's other hidden comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Onwiki comment updated in [1], per discussion at [2]; the current value results in the request being placed in the
Requests to revert undiscussed movessection instead of the intendedUncontroversial technical requestssection[3][1] Diff: https://w.wiki/GtM
[2] Discussion: https://w.wiki/GtN (permalink to current: https://w.wiki/GtP)
[3] Diff: https://w.wiki/GtQ