Add uw-upeblock to block options #851
Conversation
Per wikimedia-gadgets#850, add a new Template:Uw-upeblock, for blocks related to undisclosed paid editing, to the list of available block presets.
|
I was testing this template in my common.js and it seems to work, however, I don't know how to properly test my "dev" version of Twinkle. Please have a look and ensure that I got everything right. |
There was a problem hiding this comment.
Needs one minor fixup for proper syntax, and I've got a suggestion on language, but otherwise LGTM @wiki-ST47. Thanks for opening the PR!
I'm generally wary of adding brand new templates — who knows if they'll take off, it's easy for them to proliferate, etc. — but this does seem like a glaring omission on-wiki. I have some comments on the template itself but I'll make them there.
modules/twinkleblock.js
Outdated
| nocreate: true, | ||
| pageParam: true, | ||
| reason: '[[WP:PAID|Undisclosed paid editing]] in violation of the WMF [[WP:TOU|Terms of Use]]', | ||
| summary: 'You have been indefinitely blocked from editing because your account is being used only for [[WP:SPAM|spam or advertising]] in violation of [[WP:PAID|Wikipedia policy on paid advocacy' |
There was a problem hiding this comment.
Missing brackets to close out the link:
| summary: 'You have been indefinitely blocked from editing because your account is being used only for [[WP:SPAM|spam or advertising]] in violation of [[WP:PAID|Wikipedia policy on paid advocacy' | |
| summary: 'You have been indefinitely blocked from editing because your account is being used only for [[WP:SPAM|spam or advertising]] in violation of [[WP:PAID|Wikipedia policy on paid advocacy]]' |
There was a problem hiding this comment.
That being said, I think it'd be good to have this be in closer alignment with the log entry, if only by specifically stating it's for UPE. Maybe something like:
| summary: 'You have been indefinitely blocked from editing because your account is being used only for [[WP:SPAM|spam or advertising]] in violation of [[WP:PAID|Wikipedia policy on paid advocacy' | |
| summary: 'You have been indefinitely blocked from editing because your account is being used in violation of [[WP:PAID|Wikipedia policy on undisclosed paid advocacy]]' |
Or something like that?
| forRegisteredOnly: true, | ||
| nocreate: true, | ||
| pageParam: true, | ||
| reason: '[[WP:PAID|Undisclosed paid editing]] in violation of the WMF [[WP:TOU|Terms of Use]]', |
There was a problem hiding this comment.
I'm mixed on the use of WP:TOU here, given that it's just a soft redirect and otherwise sparse on information. I suppose it's what's currently being used by the template so it's fine?
|
@wiki-ST47 I can help make some of these changes if you'd like |
|
I updated the block summary message based on your suggestions. [[m:TOU]] might be a better choice for the wikilink, if we want to avoid the soft redirect? |
|
Is just saying UPE sufficient? Maybe a little too succinct. The template has changed a bit, but it's roughly in-line, so I say let's just give it a go, can change if need be. |
Add a new Template:Uw-upeblock, for blocks related to undisclosed paid editing, to the list of available block presets.
Per #850, add a new Template:Uw-upeblock, for blocks related to undisclosed paid editing, to the list of available block presets.