Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

morebits: use innerHTML for printUserText message header, not textContent; use in ARV #853

Merged

Conversation

Amorymeltzer
Copy link
Collaborator

Swaps textContent out for innerHTML in the p element (the header). Doing so allows the use of html (go figure), which menas we can link to AIV and UAA to close #590. Shouldn't have any noticeable effects otherwise?

Alternatively, we could add some selector to either/both printUserText elements then work on that directly.

@siddharthvp
Copy link
Member

siddharthvp commented Feb 15, 2020

Alternatively we could allow wikilink syntax in the message and setup printUserText to render the wikilinks. This would be nice to have in the Morebits.status constructor as well.

@Amorymeltzer
Copy link
Collaborator Author

That's an interesting idea for Morebits.status, what'd you have in mind? I'd imagine that'd look something like having a linkifier function that pulls out (unbinder?) anything that looks like a wikilink and passes the rest as text?

@Amorymeltzer Amorymeltzer added this to the March 2020 update milestone Feb 23, 2020
@Amorymeltzer Amorymeltzer merged commit 2bd9070 into wikimedia-gadgets:master Mar 2, 2020
@Amorymeltzer Amorymeltzer deleted the arv-linkreportings branch March 2, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARV: Add link to AIV when user has already been reported
2 participants