speedy: Fix long-standing bug in G6 copypaste notice #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I only noticed this after looking at things after wikimedia-gadgets#849, but we've been giving inaccurate notices for G6's copypaste for ages. {{db-copypaste-notice}} is just {{uw-c&pmove}} at a different title so Twinkle can handle providing the notice, but that notice uses a different format than the rest of the (standardized) csd notices. In particular, parameter `1` is *not* the page name, but rather the name of the *original* page. I *think* it's likely fine to change {{db-copypaste-notice}}, but I'm not sure if anyone else uses it and for now this is simpler.
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this pull request
Feb 29, 2020
As noted in wikimedia-gadgets#872 for the CSD module, {{uw-c&pmove}} actually takes the source of the material as the first unnamed parameter, and the target article as the `to` parameter. As users are likely to be warning an editor for the incorrect behavior, this will be populated with the target of the c&p move, so should take the `to` parameter.
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this pull request
Feb 29, 2020
As noted in wikimedia-gadgets#872 for the CSD module, {{uw-c&pmove}} actually takes the source of the material as the first unnamed parameter, and the target article as the `to` parameter. As users are likely to be warning an editor for the incorrect behavior, this will be populated with the target of the c&p move, so should take the `to` parameter. In the future, it would be nice to have an additional box just for {{uw-c&pmove}} to also list the source page, if it's known, but that'd involve a larger restructuring.
wiki-ST47
pushed a commit
to wiki-ST47/twinkle
that referenced
this pull request
Sep 2, 2020
As noted in wikimedia-gadgets#872 for the CSD module, {{uw-c&pmove}} actually takes the source of the material as the first unnamed parameter, and the target article as the `to` parameter. As users are likely to be warning an editor for the incorrect behavior, this will be populated with the target of the c&p move, so should take the `to` parameter. In the future, it would be nice to have an additional box just for {{uw-c&pmove}} to also list the source page, if it's known, but that'd involve a larger restructuring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only noticed this after looking at things after #849, but we've been giving inaccurate notices for G6's copypaste for ages. {{db-copypaste-notice}} is just {{uw-c&pmove}} at a different title so Twinkle can handle providing the notice, but that notice uses a different format than the rest of the (standardized) csd notices. In particular, parameter
1is not the page name, but rather the name of the original page. I think it's likely fine to change {{db-copypaste-notice}}, but I'm not sure if anyone else uses it and for now this is simpler.