arv: Combine AN3 queries, avoid errors, and handle revdel'd comments #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if the |
Amorymeltzer
force-pushed
the
arv-an3combo
branch
from
fa55a26
to
9f25b86
Compare
Don't print console errors if is provided: we shouldn't be unnecessarily spitting out console errors, either from null queries or mw.Title. The warnings check is fine, though. Has a more helpful API error messages, similar to wikimedia-gadgets#866.
Both in display and in posting.
Amorymeltzer
force-pushed
the
arv-an3combo
branch
from
9f25b86
to
1b62fa6
Compare
Amorymeltzer
added a commit
that referenced
this pull request
Mar 29, 2020
siddharthvp
pushed a commit
to siddharthvp/twinkle
that referenced
this pull request
Jun 27, 2020
wiki-ST47
pushed a commit
to wiki-ST47/twinkle
that referenced
this pull request
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st commit: Combine the three largely identical AN3 queries, avoid errors
Don't print console errors if is provided: we shouldn't be unnecessarily spitting out console errors, either from null queries or mw.Title. The warnings check is fine, though.
Has a more helpful API error messages, similar to #866.
2nd commit: Better text for revdel'd comments in AN3 diffs