morebits: don't handle notoken error #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notoken error code has been removed from MediaWiki. Write queries without token now return the standard missingparams error. It is anyway not necessary to handle this error since we do specify the token, so this just wouldn't ever occur. In case of expired tokens, the `badtoken` error continues to be returned, which we do handle.
|
I couldn't find a phab ticket for this, but this was announced on the Mediawiki-api-announce mailing list on 4 Feb 2020. |
|
I'll look when I get a chance, but a link to the email in the archives would be fine. |
Amorymeltzer
approved these changes
Mar 12, 2020
wiki-ST47
pushed a commit
to wiki-ST47/twinkle
that referenced
this pull request
Sep 2, 2020
notoken error code has been removed from MediaWiki. Write queries without token now return the standard missingparams error. See https://lists.wikimedia.org/pipermail/mediawiki-api-announce/2020-February/000151.html It is anyway not necessary to handle this error since we do specify the token, so this just wouldn't ever occur. In case of expired tokens, the `badtoken` error continues to be returned, which we do handle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notokenerror code has been removed from MediaWiki. Write queries without token now return the standardmissingparamserror.It is anyway not necessary to handle this error since we do specify the token, so this just wouldn't ever occur.
In case of expired tokens, the
badtokenerror continues to be returned, which we do handle.