prod: Fix a number of bugs around endorsing #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, that first bullet point should probably be split out and pushed immediately... will try to take care of that later tonight. |
Amorymeltzer
force-pushed
the
prod-blpendorseconfirm
branch
from
91bf465
to
e20b898
Compare
Most prominently, this moves the check for `{{old prod}}` to after the endorsement check, which allows proper endorsing (on the fritz since wikimedia-gadgets#735). This means that if there's a prod already present, this will allow endorsing a (regular) PROD even if the talk page has been tagged (as should be the case). This will also now *not* add another old prod template to the talk page when BLPPRODing.
Additional fixes:
- Correctly note prior tag type when endorsing
- Move article age check into new prod check, where it makes the most sense.
Amorymeltzer
force-pushed
the
prod-blpendorseconfirm
branch
from
e20b898
to
8488d56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most prominently, this moves the check for
{{old prod}}to after the endorsement check, which allows proper endorsing (on the fritz since #735). This means that if there's a prod already present, this will allow endorsing a (regular) PROD even if the talk page has been tagged (as should be the case).Additional fixes:
Fix case sensitivity bug when endorsing/checking endorsingDone in prod: Fix caps matching for {{Proposed deletion endorsed}} #975Additionally, as written, this changes things so it won't add another old prod template to the talk page when BLPPRODing. I'm on the fence about that, so would welcome feedback.