Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to use universal-router #11

Open
AJolly opened this issue Sep 16, 2023 · 1 comment
Open

Upgrade to use universal-router #11

AJolly opened this issue Sep 16, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@AJolly
Copy link

AJolly commented Sep 16, 2023

Feature request: upgrade to use Uniswaps universal router.

The new universal router lets you swap tokens/nfts, but more interestingly it allows for Permit2 - so you can execute a trade without needing to preapprove the token ahead of time.

https://blog.uniswap.org/permit2-and-universal-router
https://github.com/Uniswap/universal-router-sdk

@azerpas azerpas added the enhancement New feature or request label Sep 16, 2023
@azerpas
Copy link
Owner

azerpas commented Sep 16, 2023

I agree it would be a great addition! We discussed it already as shown below but I hadn't time to get onto it just yet.
But feel free to open a PR. 😊


Sorry for the late reply!

Effectively it seems that UniversalRouter has become the preferred entrypoint for ERC20 swaps.

At first glance it would require a bit of tweaking to support it but you're very welcome to open a PR @DiMiTriFrog. 😊

Originally posted by @azerpas in #9 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants