Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for download by URL to download music to music directory, not temporary directory. #356

Open
gittigy opened this issue Mar 12, 2023 · 4 comments
Labels

Comments

@gittigy
Copy link

gittigy commented Mar 12, 2023

Is your feature request related to a problem? Please describe.
I noticed songs that I had added by URL were often re-downloaded because they go to the temp directory and there is a temp directory size threshold to be maintained.

Describe the solution you'd like
I would like the option to download a song by URL and it be added to the music folder that uploaded music goes to. This would allow songs to be replayed without having to constantly redownload it as songs are added by URL.

Describe alternatives you've considered
I believe the size threshold can be increased but this doesn't really solve the problem.

Additional context
Botamusique is a fantastic music bot for mumble. Thank you very much for sharing such a great addition to mumble!

@wyldeTurkey
Copy link

YES. Where are the files actually being saved to? I want the files placed on the file system permanently so i can store and manage them and possibly restore them in the case of a failure. I do not want a youtube streamer. I want the youtube video's audio downloaded, labeled and stored permanently like mumble-ruby-plugin-bot. At the moment youtube streaming plugin. It should remove the word "download" from it's title.

@TerryGeng
Copy link
Collaborator

There is a quick solution: change the tmp_folder to a permanent location (I point it to my Download folder) and set tmp_folder_max_size = -1.

@gittigy
Copy link
Author

gittigy commented Apr 11, 2023

There is a quick solution: change the tmp_folder to a permanent location (I point it to my Download folder) and set tmp_folder_max_size = -1.

I tried changing the tmp_folder to my Download folder but doing so seemed to cause an error on the rescan function that is called when a file is uploaded or if the "refresh_cache_on_startup = True". I've attached a screenshot of the error.
Error_on_tmp_dir_change

I think setting "tmp_folder_max_size = -1" accomplishes the goal I'm seeking in that the temporary size threshold will never be reached, thus songs added by URL will keep being stored in the tmp directory and no songs will be deleted. Am I correct on this? If this is correct, I should be good I think.

@TerryGeng, when you changed the tmp directory, how did you avoid the errors on the refresh/rescan function? did you update something else to make this work? Thanks for your input!

@TerryGeng
Copy link
Collaborator

@gittigy Sorry for the late response. I think I have never encountered this in the past... I would guess just by changing the download path in the config, the database got confused. Could you completely delete the database and try starting fresh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants