Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes are referred to current and next_day prices #25

Closed
danimart1991 opened this issue Jul 10, 2021 · 2 comments · Fixed by #32
Closed

Attributes are referred to current and next_day prices #25

danimart1991 opened this issue Jul 10, 2021 · 2 comments · Fixed by #32

Comments

@danimart1991
Copy link

min_price, max_price, min_price_at... are referred to all the list of prices, including today and tomorrow.

I think a better option is to separate these attributes to take only one day, so it's more useful to know what is going to be the best price for both days.

@azogue
Copy link
Owner

azogue commented Jul 22, 2021

Hi @danimart1991 👋

You are totally right, last time I thought of that I added it to the TODO list for this library, but I have to find some time for it 🤦‍♂️

I want to split those attributes for today / next_day, maybe in a patch version, and also add support for other kind of prices (#9), with an optional Esios token. And, ideally, also check the new support for entity selectors in integration config flows, to try to make the long desired utility meter to measure energy cost combining price with HA energy or power sensors :)

But right now I'm on holidays, taking a well deserved rest from screens and keyboards 😬, so I don't expect to make changes in some time, maybe for summer's end

Take care 😝

@danimart1991
Copy link
Author

Hi again @azogue.

Thanks for the answer. 😉 I try myself to add some changes, but I don't have enough Python knowledge to write an optimized code and to test it well.

Enjoy the well-deserved vacation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants