Static timeout values in Conn

[h4cc]

It would be cool, if these two numbers could be part of the Conn-struct and interchangeable via options.

https://github.com/Azolo/websockex/blob/master/lib/websockex/conn.ex#L92
https://github.com/Azolo/websockex/blob/master/lib/websockex/conn.ex#L188

[Azolo]

There's no reason I can think of that they couldn't be. Feel like opening a PR?

[h4cc]

I am feeling it 💃

[h4cc]

@Azolo Might you have a look at commit ddc50b4 before PR?

[Azolo]

It looks good, I left a couple of comments.

But I think I prefer the Conn struct flat for the sake of discoverability. Someone can open up IEx and do something like:

iex> struct(WebSockex.Conn)
%WebSockex.Conn{cacerts: nil, conn_mod: nil, extra_headers: [], host: nil,
 insecure: true, path: nil, port: nil, query: nil, socket: nil, transport: nil,
 socket_connect_timeout: 6000, socket_recv_timeout: 5000}

But functionality wise, it looks spot on.

[h4cc]

Thanks for your feedback, i updated the implementation.

[Azolo]

Closed by #15