Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acts like concat? #3

Closed
yocontra opened this issue Sep 8, 2014 · 5 comments
Closed

acts like concat? #3

yocontra opened this issue Sep 8, 2014 · 5 comments

Comments

@yocontra
Copy link

yocontra commented Sep 8, 2014

Seems overly complex - shouldnt this just be applied to each file that passes through not buffering it?

@azproduction
Copy link
Owner

I used gulp-concat as a primer while developing gulp-autopolyfiller. And actually it does not buffer files: https://github.com/azproduction/gulp-autopolyfiller/blob/master/lib/index.js#L54
polyfiller.add() scans for polyfills only without buffering a code.

@yocontra
Copy link
Author

yocontra commented Sep 9, 2014

Ah I see how this works now - it outputs a new file with the polyfills in it after all files have passed through. You should document that in the README so people don't have to look through the code

@azproduction
Copy link
Owner

Done, thanks!

@yocontra
Copy link
Author

yocontra commented Sep 9, 2014

What do you think about inserting a new file into the stream with the polyfills instead of overwriting the whole stream with one file? That way you can pipe all of your JS files into this, then concat and uglify and whatever else further down the stream

@azproduction
Copy link
Owner

At the very beginning I had that idea of appending polyfills file to the stream. But then I decided that it is better to reduce input from autopolyfiller stream.
So you can generate just polyfills without filtering out your files from stream, and the basic polyfill-concat-uglify is also possible using event-stream.merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants