Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe a redundant code #8

Closed
teabroker opened this issue Oct 11, 2023 · 1 comment · Fixed by #9
Closed

Maybe a redundant code #8

teabroker opened this issue Oct 11, 2023 · 1 comment · Fixed by #9
Labels
Type: Bug Bug or Bug fixes

Comments

@teabroker
Copy link

It seems like there is some incorrectness in the code of onAbort function (at src/events-to-async.ts:119). It removes offListener from the abort event listeners. But there is no corresponding addEventListener call with offListener as an argument.
@azu azu added the Type: Bug Bug or Bug fixes label Oct 11, 2023
@azu azu linked a pull request Oct 11, 2023 that will close this issue
fix: unlisten "abort" event on offListener #9
Merged
@azu azu mentioned this issue Oct 11, 2023
Merged
@azu azu closed this as completed in #9 Oct 11, 2023
@azu
Copy link
Owner

azu commented Oct 11, 2023

Thanks!

Fixed in https://github.com/azu/events-to-async/releases/tag/v2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unlisten "abort" event on offListener azu/events-to-async
2 participants
@azu @teabroker