Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing JS from version control #71

Closed
shubham1172 opened this issue Feb 21, 2022 · 6 comments
Closed

Removing JS from version control #71

shubham1172 opened this issue Feb 21, 2022 · 6 comments
Labels
enhancement New feature or request idle

Comments

@shubham1172
Copy link
Member

The source of truth for this repository is typescript code which is transpiled into JavaScript. Since we are storing both TS and JS code (which is derived from the former), it leads to issues like #59

Question: why are we storing JS? Can we do without it?

@shubham1172
Copy link
Member Author

Also, the lib folder name does not sound right. It should be generated in a build folder instead.

@AjayKaleMS
Copy link
Contributor

Hi @shubham1172 - We shall look into this enhancement request and keep you posted.
Thanks

@BALAGA-GAYATRI BALAGA-GAYATRI added enhancement New feature or request and removed need-to-triage labels Feb 22, 2022
@shubham1172
Copy link
Member Author

@AjayKaleMS, thanks! Let me know if you have any thoughts, happy to send out a PR.

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle label Mar 8, 2022
@BALAGA-GAYATRI
Copy link
Contributor

@shubham1172 We need either .js/ docker images/ shell script for the execution of action. Please refer this for the type of custom actions. So we need js files. And lib naming convention is followed for all the azure actions and changing it right way will be difficult. We shall definitely work on your suggestion for renaming this folder.

@shubham1172
Copy link
Member Author

Sure, that's fine - another way to temporarily mitigate this is to add a step in the repository's CI, that builds and verifies the lib directory. This ensures that there is no delta between the lib in source code and the lib generated from actual typescript files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request idle
Projects
None yet
Development

No branches or pull requests

3 participants