Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block users from pull unsigned images when Policies/Content trust is enabled #698

Open
AdvanRafael opened this issue Jun 26, 2023 · 3 comments
Assignees

Comments

@AdvanRafael
Copy link

What is the problem you're trying to solve
We understand Docker Content Trust (DCT) works when calling docker cli either by parameter --disable-content-trust=false or export DOCKER_CONTENT_TRUST=1 before image operation.
So far we know several key points to DCT:

  1. ACR enable registry content trust
  2. Require docker client enable DCT itself.
  3. Only works in docker cli, not docker API.

The problems are

  1. It is difficult to teach client users do this in their end devices.
  2. Our application is rely on docker API, but docker API does not support DCT.

Describe the solution you'd like
Since Azure hosts signature server and registry server, ACR should know the image is signed or not.
We expect an option in server side, and the function works for docker cli and docker API.
When the option is enabled, only signed images can be pull. Otherwise will receive error response.
When the option is disabled, any image can be pull.

Additional context
We found Harbor already done the function. After Deployment security is enabled, neither docker cli nor docker API can not pull unsigned image.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

Copy link

github-actions bot commented Dec 6, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Dec 6, 2023
@FeynmanZhou
Copy link
Member

Hi @AdvanRafael ,

Sorry for the late response.

Based on your request, we would suggest using Notation to sign your images in ACR intead of DCT. See this doc for details.

ACR doesn't support denying pull unsigned images so far, but there is a way to deny unsigned images on its deployment.

For example, you can use admission controller to control the deployment request on Kubernetes.

How do you run your images?

@github-actions github-actions bot removed the Stale label Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants