Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client error count metric. #130

Closed
jim-minter opened this issue Jan 28, 2020 · 1 comment · Fixed by #197
Closed

Client error count metric. #130

jim-minter opened this issue Jan 28, 2020 · 1 comment · Fixed by #197
Assignees
@kwoodson
Labels
priority-high High priority issue or pull request size-small Size small

Comments

@jim-minter
Copy link
Member

jim-minter commented Jan 28, 2020 •
edited
Loading

For each of the azure, cosmos and k8s client libraries, emit a counter which increments by 1 when the API returns a non-nil err
@jim-minter jim-minter added priority-medium Medium priority issue or pull request size-small Size small priority-high High priority issue or pull request and removed priority-medium Medium priority issue or pull request labels Jan 28, 2020
@jim-minter
Copy link
Member Author

Example:

	t.m.EmitGauge("client.azure.errors", 1, map[string]string{
		"client": metric.name,
	})

@jim-minter jim-minter assigned BuckWoody and kwoodson and unassigned BuckWoody Feb 19, 2020
@kwoodson kwoodson mentioned this issue Feb 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwoodson kwoodson

Labels
priority-high High priority issue or pull request size-small Size small
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding error counters for statd clients kwoodson/ARO-RP
3 participants
@BuckWoody @jim-minter @kwoodson