[TSP] Issue summary

[dvbb]

TSP Generate issues

Plugin openapi-to-cadl reported failure

1. fatal | TypeError: Cannot read properties of undefined (reading 'properties')
2. Error: Failed to find key property opid for OpenidConnectProviderContract
3. fatal | TypeError: Cannot read properties of undefined (reading 'properties')
4. fatal | Error: Failed to find key property for RoleManagementPolicyAssignment
5. fatal | TypeError: Cannot read properties of undefined (reading 'properties')
6. fatal | Error: Failed to find key property vaultstorageconfig for BackupResourceConfigResource
7. fatal | Error: Failed to find key property default for RedisPatchSchedule

Comparison issues

1. Wrong operationId and tag

Original swagger	TSP convert swagger
DpsCertificate_CreateOrUpdate	CertificateResponses_CreateOrUpdate
DpsCertificate_GenerateVerificationCode	CertificateResponses_GenerateVerificationCode

Original swagger	TSP convert swagger
"tags": [         "IotDpsResource"     ]	"tags": [         "ProvisioningServiceDescriptions"     ]
"tags": [         "DpsCertificate"     ]	"tags": [         "CertificateResponses"     ]

2. A non-existent header parameter has been generated.

"headers": {
  "Retry-After": {
    "type": "integer",
    "format": "int32",
    "description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
  }
},

3. Some paths are missing, and the names of the paths are incorrect.

Missing:

/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/provisioningServices/{provisioningServiceName}/operationresults/{operationId}

Diff

Original: "/subscriptions/{subscriptionId}/providers/Microsoft.Attestation/attestationProviders"
TSP Convert: "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Attestation/attestationProviders/{providerName}/privateLinkResources/{resourceGroupName}/{providerName}/{subscriptionId}"

Original: /providers/Microsoft.Devices/provisioningServices/{provisioningServiceName}/keys/{keyName}/listkeys
TSP Convert: /{keyName}/providers/Microsoft.Devices/provisioningServices/{provisioningServiceName}/listKeysForKeyName

4. Many definitions names and properties therein are incorrect

a). Different definitions name.

Original swagger	TSP convert swagger
"AddonList"	"AddonListResult"
"ClusterList"	"ClusterListResult"
"complianceDetailedPdfReport"	"DownloadResponseComplianceDetailedPdfReport"
"compliancePdfReport"	"DownloadResponseCompliancePdfReport"
"ReportProperties"	"ReportResourceUpdateProperties"
"status"	"ReportStatus"
"SnapshotResourceList"	"SnapshotResourceListResult"

b). Properties therein diff.

Original swagger	TSP convert swagger
"x-cadl-name": "Dynatrace.Observability.DynatraceSingleSignOnResource[]",	-
"x-cadl-name": "FilteringTag[]",	-
-	"format": "uri",

5. Some paths lack the 202, 401 response

"401": {
  "description": "User has insufficient permissions to update SSO configuration",
  "x-ms-error-response": true
},

6. Some paths generate 202 responses that did not exist originally