fixing vm az check #235

Azure · May 9, 2024 · 67e431d · 67e431d
1 parent b24e7cb
commit 67e431d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/internal/scanners/vm/rules.go b/internal/scanners/vm/rules.go
@@ -20,7 +20,7 @@ func (a *VirtualMachineScanner) GetRules() map[string]scanners.AzureRule {
 			Impact:         scanners.ImpactHigh,
 			Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
 				v := target.(*armcompute.VirtualMachine)
-				hasZones := v.Zones != nil && len(v.Zones) > 1
+				hasZones := v.Zones != nil && len(v.Zones) >= 1
 				return !hasZones, ""
 			},
 			Url: "https://learn.microsoft.com/en-us/azure/virtual-machines/availability#availability-zones",

diff --git a/internal/scanners/vm/rules_test.go b/internal/scanners/vm/rules_test.go
@@ -28,7 +28,7 @@ func TestVirtualMachineScanner_Rules(t *testing.T) {
 		want   want
 	}{
 		{
-			name: "VirtualMachineScanner Availability Zones",
+			name: "VirtualMachineScanner No Availability Zones",
 			fields: fields{
 				rule:        "vm-002",
 				target:      &armcompute.VirtualMachine{},
@@ -39,6 +39,20 @@ func TestVirtualMachineScanner_Rules(t *testing.T) {
 				result: "",
 			},
 		},
+		{
+			name: "VirtualMachineScanner Availability Zones",
+			fields: fields{
+				rule:        "vm-002",
+				target:      &armcompute.VirtualMachine{
+					Zones: []*string{to.Ptr("1")},
+				},
+				scanContext: &scanners.ScanContext{},
+			},
+			want: want{
+				broken: false,
+				result: "",
+			},
+		},
 		{
 			name: "VirtualMachineScanner SLA 99.9%",
 			fields: fields{