Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the state not changed in the tlsio_mbedtls on_underlying_io_close_complete() #84

Closed
Resultfactory opened this issue Jun 9, 2017 · 3 comments
Assignees
Labels

Comments

@Resultfactory
Copy link

Hi,

We are using part of this utility in combination with a ESP32 chip.
We are seeing xio dowork calls after our connection has closed.
An error occurred and the state was changed to TLSIO_STATE_ERROR, the connection was being closed and after some debugging we found that the state in tlsio_mbedtls was not changed to TLSIO_STATE_NOT_OPEN, and remains in TLSIO_STATE_CLOSING state.
Which allows the dowork in tlsio_mbedtls to try and do actual work.

On line 236 and 237 we saw commented lines that would fix this problem
on_underlying_io_close_complete()

Nowhere else but the create and open functions is the state changed to TLSIO_STATE_NOT_OPEN.

Are there any reasons why these lines are commented?

@JetstreamRoySprowl
Copy link
Contributor

We've got a fix identified for this one, and are moving it through the checkin process now.

@JetstreamRoySprowl
Copy link
Contributor

The fix has been checked in to master, and will appear in the next release.

@Resultfactory
Copy link
Author

Thanks, I see it has made it's way into master 2743fea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants