Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Assistant missing return type attributes when coming from in-process model #1872

Closed
mattchenderson opened this issue Aug 30, 2023 · 3 comments
Closed

Upgrade Assistant missing return type attributes when coming from in-process model #1872

mattchenderson opened this issue Aug 30, 2023 · 3 comments
Assignees
@aishwaryabh
Labels
area: dotnet-upgrade-assistant For items tracking improvements to the Functions experience in the .NET Upgrade Assistant

Comments

@mattchenderson
Copy link
Contributor

In-process model functions could specify an output binding using the following format: [return: ServiceBus("queueName", Connection = "connectionName")]

Upgrade Assistant seems to be leaving this as-is, rather than converting it to the isolated worker model's equivalent: [ServiceBusOutput("queueName", Connection = "connectionName")]

These examples are for Service Bus specifically, but this would apply to all extensions.
@mattchenderson mattchenderson added the area: dotnet-upgrade-assistant For items tracking improvements to the Functions experience in the .NET Upgrade Assistant label Aug 30, 2023
@aishwaryabh aishwaryabh self-assigned this Oct 11, 2023
@aishwaryabh
Copy link
Contributor

PR for issue: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/UpgradeAssistant/pullrequest/503561

@fabiocav
Copy link
Member

Review currently in progress. Moving to sprint 157

@aishwaryabh
Copy link
Contributor

PR has been merged in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aishwaryabh aishwaryabh

Labels
area: dotnet-upgrade-assistant For items tracking improvements to the Functions experience in the .NET Upgrade Assistant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabiocav @mattchenderson @aishwaryabh