Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review entire public surface #81

Closed
brettsam opened this issue Jan 26, 2021 · 3 comments
Closed

Review entire public surface #81

brettsam opened this issue Jan 26, 2021 · 3 comments
Assignees
@fabiocav
Projects
.NET Worker 1.0

Comments

@brettsam
Copy link
Member

Minimize surface area for v1. Make sure that anything referencing GRPC or that couples us to System.Text.Json isn't exposed. Things like Converters can be all internal and exposed later to give us more time for API design.
@brettsam brettsam added the ga label Jan 26, 2021
@fabiocav fabiocav self-assigned this Jan 27, 2021
@fabiocav fabiocav added this to To do in .NET Worker 1.0 Jan 27, 2021
@fabiocav
Copy link
Member

First iteration done here: https://apiview.dev/Assemblies/Review/af54138c8aa0459c8e91df73dfa71e98

@brettsam
Copy link
Member Author

brettsam commented Mar 8, 2021

Will do one final review pre-1.0

@fabiocav
Copy link
Member

Last round or reviews completed. Added with #262

@fabiocav fabiocav moved this from To do to Done in .NET Worker 1.0 Mar 25, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fabiocav fabiocav

Labels
None yet
Projects
No open projects
.NET Worker 1.0
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettsam @fabiocav