Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit test failures of test_get_ovf_env_missing_{password,three} #30

Closed
dongsupark opened this issue Jan 19, 2024 · 0 comments · Fixed by #32
Closed

Fix unit test failures of test_get_ovf_env_missing_{password,three} #30

dongsupark opened this issue Jan 19, 2024 · 0 comments · Fixed by #32

Comments

@dongsupark
Copy link
Collaborator

Running cargo test results in failures like:

test media::tests::test_get_ovf_env_missing_password ... FAILED
test media::tests::test_get_ovf_env_missing_three ... FAILED

It should be fixed before working on GitHub Actions CI.
@dongsupark dongsupark mentioned this issue Jan 19, 2024
Closed
6 tasks
@dongsupark dongsupark mentioned this issue Jan 30, 2024
Merged
anhvoms pushed a commit that referenced this issue Jan 31, 2024
@dongsupark
fix unit tests password of test_get_ovf_env_missing_* (#32)
3068896 
Fix failures in unit tests `test_get_ovf_env_missing_password`,
`test_get_ovf_env_missing_three`, by checking for errors instead of
actual values.
As `parse_ovf_env` is expected to return errors if the password is
empty, it is not necessary to check other returned fields.

Fixes #30

## Testing done

`cargo test` passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix unit tests password of test_get_ovf_env_missing_* Azure/azure-init
1 participant
@dongsupark