Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Remove NTPClient used in SAMD examples #6

Closed
sandeepmistry opened this issue Apr 5, 2016 · 4 comments
Closed

Remove NTPClient used in SAMD examples #6

sandeepmistry opened this issue Apr 5, 2016 · 4 comments
Assignees

Comments

@sandeepmistry
Copy link
Contributor

No description provided.

@obsoleted
Copy link
Contributor

I am still a bit torn on this. I understand wanting to make the samples/sketches as concise as possible. However, this type of functionality does seem out of scope for the the library itself.
I wonder if there is another NTP library that exists (or maybe one can be made) that we could use in the samples that would limit the code there but just add another dependency.

While NTP and Wifi are requirements for using the library successfully it feels odd to move the configuration of them into the library. Should these libraries want to expose new initial configuration options then this library would also need to be updated instead of just benefiting from new functionality.

@sandeepmistry
Copy link
Contributor Author

@obsoleted good points, I'll submit a patch to this repo to also support non-ESP8266 boards: https://github.com/FWeinb/NTPClient

Then we can use it in the examples like you suggested.

I'll rename this issue accordingly.

@sandeepmistry sandeepmistry changed the title Move NTPClient out of examples and into library with helper function Remove NTPClient used in SAMD examples Apr 8, 2016
@sandeepmistry sandeepmistry self-assigned this Apr 8, 2016
@sandeepmistry
Copy link
Contributor Author

I've submitted the following PR to the NTPClient repo: arduino-libraries/NTPClient#8

@sandeepmistry
Copy link
Contributor Author

Closed via #16.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants