-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
createFcmNotification - ServiceBusNotification-Format "gcm" vs "fcm", #44
Comments
@hangryfabian Did you get the solution for the above problem statement. Even I'm facing the same issue and being forced to FCM from google. |
No :( |
The C# equivalent code sends "gcm" too - thanks to line 1794 of NotificationHubClient.cs In the SendNotificationImplAsync method we have Problems could be caused by FcmRegistration. This sends a GcmRegistrationDescription entity in the XML whereas the C# equivalent sends an FcmRegistrationDescription entity. However, the C# code also converts any GcmRegistrationDescription objects that it receives to FcmRegistrationDescription objects so the back-end could handle this. |
As noted on our ReadMe that GCM is the only valid value as FCM will throw an error as we do not fully support the FCM protocol, only the FCM-Legacy protocol via the GCM setting. |
In a previous commit I see ServiceBusNotification-Format as "fcm", but in the recent ones it is "gcm". When I changed it to "fcm", the push notifications do not work (our client app is using FCM).
I'm not sure how this is handled by Azure Hub in the background, but the force over to FCM is in a few weeks, so just want to confirm "gcm" in the below function will still work after that date?
Thanks!
The text was updated successfully, but these errors were encountered: