Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17 App Service Operations Return Abnormal 404 and 409 #261

Closed
selvasingh opened this issue Apr 21, 2016 · 2 comments
Closed

17 App Service Operations Return Abnormal 404 and 409 #261

selvasingh opened this issue Apr 21, 2016 · 2 comments

Comments

@selvasingh
Copy link
Contributor

#17 App Service Operations Return Abnormal 404 and 409

Numerous Create, Delete, Update and Reboot operations in the App Service Swagger spec return abnormal 404 and 409. Developers will not be able to differentiate request succeeded OR accepted versus resource was not found OR there is a conflict. When a resource is not found or there is a conflict, an exception will not be thrown.

    "responses": {
      "200": {
        "description": "OK",
        "schema": {
          "$ref": "#/definitions/Object"
        }
      },
      "202": {
        "description": "Operation is in progress",
        "schema": {
          "$ref": "#/definitions/Object"
        }
      },
      "400": {
        "description": "Bad request"
      },
      "404": {
        "description": "Not found"
      },
      "409": {
        "description": "Conflict"
      }
    },

If an operation encounters an abnormal condition that it cannot handle, it should throw an exception. If an operation is throwing an exception for an abnormal condition that we feel that developers should consciously decide how to handle, then throw a checked exception in a client library with sufficient information. A client library cannot through an exception if an operation does not define errors in Swagger.

Are these 404 and 409 definitions intentional?

Here is a SAMPLE list of those 404 and 409 occurrences -

@devigned
Copy link
Member

@Azure/adx-autorest-contributors and @Azure/openapi-advisors any thoughts on this issue?

@kirthik
Copy link
Contributor

kirthik commented Feb 10, 2017

@kirthik kirthik closed this as completed Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants