Naming of DiskEncryptionSettings properties

[anuchandy]

Currently VM's disk encryption settings is defined as below:

"DiskEncryptionSettings": {
      "properties": {
        "diskEncryptionKey": {
          "$ref": "#/definitions/KeyVaultSecretReference",
          ...
        },
        "keyEncryptionKey": {
          "$ref": "#/definitions/KeyVaultKeyReference",
          ...
        },
        ...
      },
      "description": "Describes a Encryption Settings for a Disk"
}

DiskEncryptionSettings:

The naming of properties are bit confusing - diskEncryptionKey, keyEncryptionKey. names such as keyVaultSecretReference and keyVaultKeyReference will be better. Similar to imageReference

I know we cannot introduce breaking changes in server, but we could use x-ms-client-name so that atleast generated code will have better variable name.

@huangpf @devigned @amarzavery

[huangpf]

@hyonholee This is initially requested by the disk encryption team. Could you please help involve them? Thanks.

[ejarvi]

I was not involved with the initial design or selection of these property names, but what I do know is that the disk encryption key is different from the key encryption key. It would be valuable to preserve some distinction in the property name that would indicate which one is for the disk encryption key and which one is for the key encryption key.

https://docs.microsoft.com/en-us/azure/security/azure-security-disk-encryption#terminology

[salameer]

Closing due to inactivity. Anu please reopen if this is still an issue