Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Failed build service bus client in weekly pipeline test #27509

Closed
v-hongli1 opened this issue Mar 8, 2022 · 5 comments
Closed
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. needs-team-triage This issue needs the team to triage. Service Bus test-sovereign-cloud
Milestone

Comments

@v-hongli1
Copy link
Contributor

v-hongli1 commented Mar 8, 2022

We are running live tests against other clouds like US Gov and Azure China Cloud. The goal is to check whether new azure sdk package work with other clouds or not.

Error Description:
When running the integration test ServiceBusClientBuilderTest.customNoneProxyConfigurationBuilder on Public and UsGov and China cloud, it returns the error java.lang.IllegalStateException: Cannot build client without setting either a ***Name or ***Name.. The error message is shown as following, for more details please check here.

Error Tracking:
Code Link:
image

Expected Behavior:
The ServiceBus Client can also be builded successfully when using the connection string in this format [Endpoint=%s;SharedAccessKeyName=%s;SharedAccessKey=%s;EntityPath=%s].

Suggestion:
Update if (CoreUtils.isNullOrEmpty(entityPath)) to if (!CoreUtils.isNullOrEmpty(entityPath))

@benbp, @joshfree, @lilyjma, @ramya-rao-a and @ZejiaJiang for notification.

@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Mar 8, 2022
@v-xuto v-xuto added Client This issue points to a problem in the data-plane of the library. needs-team-triage This issue needs the team to triage. Service Bus test-sovereign-cloud labels Mar 8, 2022
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Mar 8, 2022
@v-xuto
Copy link
Member

v-xuto commented Mar 15, 2022

@benbp, @joshfree, @lilyjma, @ramya-rao-a and @ZejiaJiang
Do you have any idea about this issue?

@benbp
Copy link
Member

benbp commented Mar 16, 2022

It seems like this is one of many potential issues, as the service bus live tests have been in a failing state for various reasons for almost a year. @ki1729 perhaps?

@ki1729
Copy link
Contributor

ki1729 commented Mar 16, 2022

The tests have been failing and I did make some changes to them at one point. @hongli750210 how pressing is the issue for you folks?

@v-hongli1
Copy link
Contributor Author

v-hongli1 commented Mar 17, 2022

@ki1729 This is not particularly urgent. It's better if you can fix it in a few days, but a month or two is ok. This issue affects the pipeline weekly test for other clouds like US Gov and Azure China Cloud.

@ki1729 ki1729 self-assigned this Mar 23, 2022
@ki1729 ki1729 added this to the [2022] April milestone Mar 23, 2022
@ki1729 ki1729 added this to To do in Azure AMQP - Nickel via automation Mar 23, 2022
ki1729 added a commit that referenced this issue Mar 24, 2022
…ring in ServiceBusClientBuilder

* Fixed handling of entity name when present in connection string - bug #27509
@v-hongli1
Copy link
Contributor Author

Close this issue, because it fixed by PR #27840

Azure AMQP - Nickel automation moved this from To do to Done Mar 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. needs-team-triage This issue needs the team to triage. Service Bus test-sovereign-cloud
Projects
No open projects
Development

No branches or pull requests

4 participants