Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identified Areas for filling gap between azure-core and clientcore #40465

Open
samvaity opened this issue Jun 3, 2024 · 1 comment
Open

Identified Areas for filling gap between azure-core and clientcore #40465

samvaity opened this issue Jun 3, 2024 · 1 comment
Labels
needs-triage This is a new issue that needs to be triaged to the appropriate team.

Comments

@samvaity
Copy link
Member

samvaity commented Jun 3, 2024

Identified Areas for filling gap between azure-core and clientcore

  1. Policies: Support for more general policies like, user agent policy, cookie policy, addHeaders.

Going through policies case-by-case to investigate the need for "lift & shift" with openrewrite without async-ness, or filtering azure specific details from the policies only applying what is needed for generic concept of the policy.

  1. Serialization: Missing API support for custom serializer/adapter from user.

NEED TO CONFIRM

  1. Response Handling: The need for ResponseBase with strongly typed headers. (with lazily invoked headers, so that the typed headers the values aren't converted until access time)

Don't need this in client-core

  1. Pagination: Support for paged responses and LRO operations.

Support pagination in client-core, with "lift & shift" with openrewrite without async-ness

  1. Authentication: Missing support for TokenCredential points to a gap in the authentication mechanisms.

Follow up issue filed.

  1. Policy positioning: The concept of adding before and after retry policies for handling transient errors and ensuring reliable retries/redirects.

NEED TO CONFIRM

  1. ServiceVersion: Missing support for ServiceVersion, there is no mechanism to handle different versions of the API.

Support in client-core, with "lift & shift" with openrewrite without async-ness

  1. Compatibility with azure-core: Utilize azure-core's shared primitives, abstractions, and helpers to maintain consistency Azure SDK client libraries.

Extend and re-use as much as we can to take the easy wins, but where it cannot, make intentional choices for the new state/models.

  1. Tracing: Missing support for tracing.

Follow up with Liudmila, for the approach we want to undertake for client-core tracing.

  1. Minor:
    • Missing #NONE configuration, lack of default settings or a way to handle unspecified configurations.
@github-actions github-actions bot added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Jun 3, 2024
@robsimpson
Copy link
Contributor

HI Sameeksha

The only thing I have noted that isn't mentioned above is com.azure.core.client.traits.* - is missing some that were used in the app config SDK, ConnectionStringTrait in particular. Am guessing similar to policies, in that if it's required it should be pretty simple to lift/shift?

Rob S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage This is a new issue that needs to be triaged to the appropriate team.
Projects
None yet
Development

No branches or pull requests

2 participants