Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to properly handle null for blob container names #83

Closed
jcookems opened this issue May 20, 2012 · 9 comments
Closed

Need to properly handle null for blob container names #83

jcookems opened this issue May 20, 2012 · 9 comments

Comments

@jcookems
Copy link
Contributor

When null is passed as the container name in the Blob service APIs, it maps to the container named "null", which is not the intended behavior. It should throw an exception, or interpret null as the root container (which would be consistent with passing the empty string, see issue #82).

@gcheng
Copy link

gcheng commented Jul 10, 2012

I think this should be fixed with unit test(s). root container is an important scenario to support.

@joostdenijs
Copy link
Contributor

null value should go to root (same as empty string)

@ghost ghost assigned gcheng Jul 13, 2012
@gcheng
Copy link

gcheng commented Jul 17, 2012

It depends on the method, for create container, it doesn't make sense to send the create container request because the root container is already there.

@joostdenijs
Copy link
Contributor

I think that null should be the root container everywhere, and in the case of create container, the request to create the root container will fail server side.

@gcheng
Copy link

gcheng commented Jul 17, 2012

also for delete container, if we do not curb the request on client side, an incorrect delete container may delete the whole account in future.

@gcheng
Copy link

gcheng commented Jul 19, 2012

fix ready.

@gcheng
Copy link

gcheng commented Jul 21, 2012

actually, no, it is more complicated than it looks like.

http://msdn.microsoft.com/en-us/library/windowsazure/ee395424.aspx

@gcheng
Copy link

gcheng commented Jul 21, 2012

To list the blobs in the root container:
GET http://myaccount.blob.core.windows.net/$root?restype=container&comp=list

To delete the root container:
DELETE http://myaccount.blob.core.windows.net/$root?restype=container

Missed from documentation, I guess creating a root container should be

PUT http://myaccount.blob.core.windows.net/$root?restype=container

@gcheng
Copy link

gcheng commented Jul 21, 2012

actually, if we always specify the root container as $root, the amount code change seems to be minimum.

@gcheng gcheng closed this as completed Jul 27, 2012
joostdenijs pushed a commit to joostdenijs/azure-sdk-for-java that referenced this issue Jan 18, 2013
joostdenijs pushed a commit to joostdenijs/azure-sdk-for-java that referenced this issue Jan 18, 2013
convert to dev style java doc for writeable blob container contract.
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this issue Apr 5, 2017
convert to dev style java doc for writeable blob container contract.
g2vinay pushed a commit to g2vinay/azure-sdk-for-java that referenced this issue Mar 4, 2019
Remove setting inferred tier when listing
mssfang pushed a commit to mssfang/azure-sdk-for-java that referenced this issue Apr 23, 2019
Renaming ReceiveBySequenceNumberAsync to ReceiveDeferredMessageAsync as it makes the scenario clear.
g2vinay pushed a commit to g2vinay/azure-sdk-for-java that referenced this issue May 30, 2019
navalev pushed a commit to navalev/azure-sdk-for-java that referenced this issue Dec 24, 2019
* Add tests for merge action

* Implement and use mergeDocument, mergeOrUploadDocument operations

* Refactor merge related test methods to call client.mergeDocument

* Re-run test records
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants