Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlobService.get_page_ranges should support timeout parameter #65

Closed
pneumee opened this issue Oct 28, 2015 · 4 comments
Closed

BlobService.get_page_ranges should support timeout parameter #65

pneumee opened this issue Oct 28, 2015 · 4 comments

Comments

@pneumee
Copy link

pneumee commented Oct 28, 2015

https://msdn.microsoft.com/en-us/library/azure/ee691973.aspx

A timeout parameter is supported by the API, but not implemented in the SDK. The default seems very short (~ 25 seconds).

@emgerner-msft
Copy link
Member

Right now the library supports setting a service-wide timeout by specifying the timeout parameter in the blob service initialization. This is then used in the underlying Python request session for all the APIs. You can set it higher than the default if desired, but note the limitations for the server will still apply.

The current plan for the future version of the library is to not set a default on the service. We will then look at adding timeout to some (the more timeout sensitive) or all APIs. We're still considering exact design, so if you have in mind what you'd like to see ideally we're happy to chat.

@pneumee
Copy link
Author

pneumee commented Oct 28, 2015

Setting that timeout doesn't seem to have any affect. I had it set to 300, it still timed out after 25 seconds. Seems like the service-wide setting when creating a BlobService object is client-side, while the timeout setting passed to the API is server-side?

@emgerner-msft
Copy link
Member

Yes, this is correct. The older library sets the timeout you specify on the underlying Python session request (ie, client side). The server timeout will not be set meaning the service defaults I linked to above will be applied on the server. I'll modify the above response to make that clearer.

In the newer version we will set both the server timeout (sent in the query) and a client side timeout on the request (like currently). Sending a server timeout isn't very helpful if the connection is lost for some reason, so the client side timeout is good to have in addition. How these interplay is an interesting design point, and how we want to expose this well is a discussion we're currently having.

@emgerner-msft
Copy link
Member

We have released the 0.30 version (#132) which addresses this feature request.

The timeout parameter supported by the REST API is now exposed for every method in the SDK which makes service calls. Client side timeout is not out yet (still being designed), but my understanding of this initial question is just for server timeout. If you have issues with the new version in regards to this issue, please reopen it and continue the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants