Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use eslint and prettier #59

Closed
swissarmykirpan opened this issue Jul 16, 2018 · 2 comments
Closed

use eslint and prettier #59

swissarmykirpan opened this issue Jul 16, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@swissarmykirpan
Copy link

No description provided.

@XiaoningLiu XiaoningLiu added the enhancement New feature or request label Jul 18, 2018
@edwin-huber
Copy link
Collaborator

Hi @swissarmykirpan ,
in the core team, we are using VSCode, and this has a JSHint plugin.
I'll add the jshint configuration to the project.

As far as prettier goes :
@pdressel / @pmanlukas / @XiaoningLiu
Any reason you have not to specify a standard formatting to the code now, and run it through prettier?
So far I just used the vscode defaults, but we can be a bit more stringent wrt. function calls etc.

Thoughts?

@edwin-huber
Copy link
Collaborator

This is now applied and we are using jshint 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants