Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Support for Terraform 0.13 #45

Closed
6 tasks done
arnaudlh opened this issue Jun 17, 2020 · 4 comments · Fixed by #75
Closed
6 tasks done

[feature] Support for Terraform 0.13 #45

arnaudlh opened this issue Jun 17, 2020 · 4 comments · Fixed by #75
Assignees
Labels
landingzone_caf_foundations Related to landingzone_caf_foundations landingzone_hub_mesh landingzone_hub_spoke Related to landingzone_hub_spoke landingzone_secure_vnet_dmz Related to landingzone_secure_vnet_dmz landingzone_vdc_demo Related to landingzone_vdc_demo

Comments

@arnaudlh
Copy link
Member

arnaudlh commented Jun 17, 2020

Proposal

Add support for Terraform 0.13 in two waves:

  1. Compatible: able to run on Terraform 13. possibly on Terraform 12.
  2. Optimized: leverage Terraform 13: for landing zones leverage features as count for_each depends_on.

Landing zones

  • landingzone_vdc_demo
  • landingzone_hub_spoke
  • landingzone_caf_foundations
  • landingzone_secure_vnet_dmz
  • landingzone_hub_mesh

Dependencies

@arnaudlh arnaudlh added landingzone_vdc_demo Related to landingzone_vdc_demo landingzone_hub_spoke Related to landingzone_hub_spoke landingzone_caf_foundations Related to landingzone_caf_foundations landingzone_secure_vnet_dmz Related to landingzone_secure_vnet_dmz landingzone_hub_mesh labels Jun 17, 2020
@frodopackets
Copy link

When trying to instantiate landingzone_caf_foundations on 0.13beta2 via TFE or the local binary, I'm observing issues where its trying to find the azurecaf provider within aztfmod (this is signed and successful) as well as the hashicorp namespace (this is not for obvious reasons). Since it fails to find azurecaf in the hashicorp namespace the plan fails. This doesn't happen unless I start taking advantage of the blueprint/modules - just setting the required provider and using an azurecaf resource works fine. I can't seem to locate where the problem might be. At first I assumed we just had an azurecaf provider called out in a module/submodule without the aztfmod namespace being defined but I can't find it. I even removed version pinning to see if I was leveraged an out of date module. Obviously 0.13 is beta, and this is still work in progress - but it seemed worth calling out the issue here since it seemed to be working for TFC in the demo on youtube.

@arnaudlh
Copy link
Member Author

arnaudlh commented Jun 30, 2020

Hi @frodopackets, we use the provider from the registry, available here
and you should call it using:

terraform {
  required_providers {
    azurecaf = {
      source = "aztfmod/azurecaf"
    }
  }
}

The hashicorp/azurecaf error message you are referring to - is due to modules trying to locate the provider "the old way".

Updated modules are now in test and you can check the code I'm using for the demo here: https://github.com/arnaudlh/caf-terraform-landingzones-tfc/tree/master/landingzones/landingzone_caf_foundations

HTH.

arnaudlh added a commit that referenced this issue Jul 6, 2020
arnaudlh added a commit that referenced this issue Jul 7, 2020
arnaudlh added a commit that referenced this issue Jul 13, 2020
@arnaudlh
Copy link
Member Author

Working branch for this one is vnext13 - https://github.com/Azure/caf-terraform-landingzones/tree/vnext13

@arnaudlh arnaudlh self-assigned this Jul 20, 2020
@arnaudlh
Copy link
Member Author

since GA of Terraform 0.13 has been pushed to 10th August as per hashicorp/terraform#25016
we will align and release 13 capabilities in 2008 (august release). in the meantime you can still use the vnext13 branch (https://github.com/Azure/caf-terraform-landingzones/tree/vnext13) to follow the updates

@arnaudlh arnaudlh linked a pull request Sep 3, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
landingzone_caf_foundations Related to landingzone_caf_foundations landingzone_hub_mesh landingzone_hub_spoke Related to landingzone_hub_spoke landingzone_secure_vnet_dmz Related to landingzone_secure_vnet_dmz landingzone_vdc_demo Related to landingzone_vdc_demo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants