Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate dependencies in elastic search output #385

Closed
arwyl opened this issue Apr 22, 2021 · 3 comments
Closed

Duplicate dependencies in elastic search output #385

arwyl opened this issue Apr 22, 2021 · 3 comments
Assignees
@karolz-ms
Labels
bug

Comments

@arwyl
Copy link

arwyl commented Apr 22, 2021

https://github.com/Azure/diagnostics-eventflow/blob/master/src/Microsoft.Diagnostics.EventFlow.Outputs.ElasticSearch/ElasticSearchOutput.cs

As I can see code blocks from lines 154-165 and 167-178 are identical

so dependencies are yielded twice
@karolz-ms karolz-ms added the bug label Apr 23, 2021
@karolz-ms
Copy link
Collaborator

karolz-ms commented Apr 23, 2021 •
edited
Loading

😔 Sorry about that @arwyl Good catch! We'll try to fix it ASAP

karolz-ms added a commit to karolz-ms/diagnostics-eventflow that referenced this issue May 7, 2021
@karolz-ms
Remove duplicate code in Elasticseearch output
ea41de9 
Fixes Azure#385
@karolz-ms karolz-ms mentioned this issue May 7, 2021
Merged
@karolz-ms
Copy link
Collaborator

Re-opening till new NuGets are published

@karolz-ms karolz-ms reopened this May 18, 2021
@karolz-ms karolz-ms self-assigned this May 18, 2021
@karolz-ms
Copy link
Collaborator

Elasticsearch output package 2.7.3 has been published to nuget.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karolz-ms karolz-ms

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arwyl @karolz-ms