-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid steps workflow collection #241
Comments
SummaryThe first is trying to deep copy handlerProperties from the update manifest, which is needed by apt content handler. In fact, it needs "installedCriteria" property in the handlerProperties. ResolutionThe update manifest from the logs shows there is no "handlerProperties" property for step 0: "instructions": {
"steps": [
{
"handler": "microsoft\/apt:1",
"files": [
"fb42001e3d0d13a3b"
]
}
]
} Instead, the import manifest should have something like: "instructions": {
"steps": [
{
"handler": "microsoft\/apt:1",
"handlerProperties": {
"installedCriteria": "1.0"
},
"files": [
"fb42001e3d0d13a3b"
]
}
]
} ExplanationIt uses "installedCriteria" to determine if the update needs to be installed or not. Ideally, the APT content handler should query APT/dpkg to determine if the packages in the apt manifest are installed or not, but since it can be set of package adds and deletions (by prefixing When apt packages are installed (or removed if Possibly Confusing Documentationhttps://learn.microsoft.com/en-us/azure/iot-hub-device-update/import-schema#inlinestep-object that shows handlerProperties is not required which is true in general for a custom content handler, but for APT and other 1st party content handlers, they require at least this: "handlerProperties": {
"installedCriteria": "1.0"
}, We're looking into how to make this less confusing. Detailed Analysis-2143289331 is hex ffff ffff 8040 000d which from https://github.com/Azure/iot-hub-device-update/blob/main/src/inc/aduc/result.h#L1321 is:
From steps-handler.20221103-155849.log:
This corresponds to code in
where it is trying to copy "handlerProperties" property. |
Thank you very much for the detailed response. I used the az cli to create the update manifest, perhaps additional logic is needed there to properly create the manifest file with all required properties. I also noticed due to fat fingering that you can set an invalid update handler via the CLI. I'll try this and let you know results. |
It's working as expected - Thank you |
Glad it's working. Cheers! |
Hello,
I am receiving the following error on my published update:
Extended result code: -2143289331
Description: Invalid steps workflow collection
Attached are the update import manifest, apt manifest and device logs. I can't seem to find anything on the logs that tells me what the invalid step is. (renamed files with .txt extension for upload reasons)
aziot-edge-1.4.2.2-apt-manifest.txt
aziot-edge-1.4.2.2.importmanifest.txt
du-agent.20221103-155619.log
steps-handler.20221103-155849.log
The text was updated successfully, but these errors were encountered: