Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to ignore error from certificate auto signed #113

Closed
jbaojunior opened this issue Jan 26, 2021 · 8 comments
Closed

Option to ignore error from certificate auto signed #113

jbaojunior opened this issue Jan 26, 2021 · 8 comments
Labels
bug Something isn't working

Comments

@jbaojunior
Copy link

I am trying to use the optional args to pass --insecure-skip-tls-verify but this is not working. Has some way to do this?

    - uses: Azure/k8s-deploy@v1.3
      with:
        manifests: |
          /tmp/deployment.yaml
        images: deploy-service:${{ env.ENVIRONMENT }}
        args: '--insecure-skip-tls-verify=true'
@thesattiraju thesattiraju added the bug Something isn't working label Feb 15, 2021
@shigupt202
Copy link
Contributor

@jbaojunior We are not supporting arguments currently for any of the actions in K8s-deploy.
@DS-MS Is there any reason why we didn't support arguments here, and in the task either (arguments are allowed only for delete action in KubernetesManifest task)?

@thesattiraju
Copy link
Contributor

thesattiraju commented Mar 15, 2021

In case of deploy we run multiple kubectl commands, like apply, annotate, rollout, delete mapping those args to a single command was tricky. So I suppose we removed args support altogether. We should get rid of the input though, I don't think it's being used anywhere or evaluate using args against our apply commands

@shigupt202
Copy link
Contributor

That's right. The input is not being used anywhere in this action.

@koushdey
Copy link
Contributor

Closing it against the PR #139

@maxisam
Copy link

maxisam commented Sep 5, 2021

@koushdey Why this issue is closed? The PR doesn't fix the problem.

@koushdey
Copy link
Contributor

koushdey commented Sep 6, 2021

@maxisam The PR is removing the support for the broken functionality of optional input param which gave rise to this issue. The input param was present but was not consumed during runs.

@shigupt202 shigupt202 removed their assignment Sep 6, 2021
@maxisam
Copy link

maxisam commented Sep 7, 2021

@koushdey so what about the problem of having an option to ignore error from certificate auto signed?

I thought the whole issue is about that. Am I the only one feel this way? lol

Yes, there was a bug but IMO that was not the point of the issue.

@Lippur
Copy link

Lippur commented Jan 17, 2022

I agree that this should be reopened. Right now, it is not possible to deploy to clusters which use a self-signed certificate. The issue here was not that it seemed possible to pass arguments, it's that it isn't possible to pass arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants