Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review parameter names (esp. MS SQL params) in azuredeploy.json #53

Closed
SorraTheOrc opened this issue Mar 17, 2018 · 1 comment
Closed

Review parameter names (esp. MS SQL params) in azuredeploy.json #53

SorraTheOrc opened this issue Mar 17, 2018 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers Priority 1 (may address) Pull Requests very welcome, but we are unlikely to get to this ourselves.

Comments

@SorraTheOrc
Copy link
Contributor

Some of the parameter names are sub-optimal, for example serviceObjective, skuCapacityDTU and more.

We should do a complete review of all parameter names and make them more intuitive.

This will have an impact on the documentation of these parameters (#36)
@SorraTheOrc SorraTheOrc added enhancement New feature or request good first issue Good for newcomers Priority 1 (may address) Pull Requests very welcome, but we are unlikely to get to this ourselves. labels Mar 17, 2018
@SorraTheOrc SorraTheOrc mentioned this issue Mar 19, 2018
Closed
@SorraTheOrc
Copy link
Contributor Author

The problem of bad naming (and duplicates) is particularly prevalent in the database configuration. We need to simplify this overall

@hosungsmsft hosungsmsft changed the title Review parameter names in azuredeploy.json Review parameter names (esp. MS SQL params) in azuredeploy.json Mar 21, 2018
@hosungsmsft hosungsmsft mentioned this issue Mar 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers Priority 1 (may address) Pull Requests very welcome, but we are unlikely to get to this ourselves.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SorraTheOrc