Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Base URLs in azuredeploy.json and README.md should be checked #89

Open
hosungsmsft opened this issue Apr 20, 2018 · 0 comments
Open

CI: Base URLs in azuredeploy.json and README.md should be checked #89

hosungsmsft opened this issue Apr 20, 2018 · 0 comments
Labels
Priority 0 (will address) Pull requests welcome, failing that we will get to this ASAP.
Milestone
v1.5.1

Comments

@hosungsmsft
Copy link

A PR from a different branch or from a different fork shouldn't update the base URLs in azuredeploy.json and README.md (the ones with https://raw.githubusercontent.com/Azure/Moodle/master). We should add a step in CI to make sure these values are not changed and reject the PR if any of those are changed.
@hosungsmsft hosungsmsft added this to the v1.5.1 milestone Apr 20, 2018
@hosungsmsft hosungsmsft added the Priority 0 (will address) Pull requests welcome, failing that we will get to this ASAP. label Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority 0 (will address) Pull requests welcome, failing that we will get to this ASAP.
Projects
None yet
Milestone
v1.5.1
Development

No branches or pull requests
1 participant
@hosungsmsft