Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rds-deployment/rds-update-certificate/scripts/Script.ps1 removing external dependency impersonate #16

Closed
jagilber opened this issue May 13, 2017 · 1 comment
Closed

rds-deployment/rds-update-certificate/scripts/Script.ps1 removing external dependency impersonate #16

jagilber opened this issue May 13, 2017 · 1 comment
Assignees
@jagilber
Labels
5-RDS-on-Windows-Server

Comments

@jagilber
Copy link
Member

rds-deployment/rds-update-certificate/scripts/Script.ps1 removing external dependency on gallery script
new-impersonateuser.ps1

reasons:

  • external dependency url link could be inadvertently changed due to gallery design
  • logic in gallery script is small (calls win32 advapi32 LogonUser)
  • no commit history in gallery
  • can easily be incorporated to potentially improve resiliency

submitting PR after final testing
@jagilber jagilber mentioned this issue Jun 2, 2017
Merged
afilenkov added a commit that referenced this issue Jul 19, 2017
@afilenkov
Merge pull request #21 from jagilber/iss18
2935874 
fix Issues #12 #14 #15 #16 #18 rds-update-certificate script.ps1
@afilenkov
Copy link
Contributor

Merged into develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagilber jagilber

Labels
5-RDS-on-Windows-Server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mmarch @jagilber @ChristianMontoya @afilenkov