-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: Failed to download Helm from location https://get.helm.sh/helm-v1.2.1-linux-amd64.zip #99
Error: Failed to download Helm from location https://get.helm.sh/helm-v1.2.1-linux-amd64.zip #99
Comments
facing the same issue |
Faced the same issue but replaced
|
got same problem, the download link was updated or something ? |
Getting same problem Adding version solved it
|
They relied on the default ordering of the GH GQL api and that probably got changed... Changing the query used here and loosing the reverse (why do that if the API can do it for you?): Lines 58 to 73 in b70d33f
query {
repository(name: "helm", owner: "helm") {
releases(first: 10, orderBy: {field: CREATED_AT, direction: DESC}) {
nodes {
tagName
}
}
}
} Maybe I find time to PR this, but if somebody wants to do it be my guest! |
Due to Azure/setup-helm#99, this pins the version to v3.10.1 as a temporary fix.
Due to Azure/setup-helm#99, this pins the version to v3.10.1 as a temporary fix.
But even when an order is added some computation of the latest need to be done. The latest could be some patch for previous major/minor. |
@marcindabrowski / @vdhpieter we might want to use the So a slight modification to @vdhpieter 's query ... query {
repository(name: "helm", owner: "helm") {
releases(first: 10, orderBy: {field: CREATED_AT, direction: DESC}) {
nodes {
tagName
isLatest
isDraft
isPrerelease
}
}
}
} ... and then adapting the processing (ref: src/run.ts#L71-L75 might do the trick: // ...
const latestValidRelease: string = repository.releases.nodes
.find(
({tagName, isLatest, isDraft, isPreRelease}) =>
isValidVersion(tagName) && isLatest && !isDraft && !isPreRelease
)?.tagName
if (latestValidRelease) return latestValidRelease
// ... Related: recent announcement that the meaning of the
|
#100 will be merged in and released shortly. That fixes this issue. Thanks everyone for the help! |
The linked PR was merged but this still isn’t resolved, are we waiting for anything else? |
Ah ok was looking at clusterpedia-io/clusterpedia-helm#15 |
This has been fixed and released in v3.4 (and v3). Please upgrade to one of these versions. Thanks! |
What happened?
Version
Runner
Ubuntu 20.04.5
Relevant log output
https://github.com/coder/code-server/actions/runs/3316135595/jobs/5478071781
The text was updated successfully, but these errors were encountered: