Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if Azure Functions Core Tools is available before starting the api #38

Closed
manekinekko opened this issue Dec 5, 2020 · 0 comments
Closed

Check if Azure Functions Core Tools is available before starting the api #38

manekinekko opened this issue Dec 5, 2020 · 0 comments
Assignees
@manekinekko
Labels
priority: high (P0) High priority scope: api Issues related to the user's application API scope: cli Issues happened a the ./src/cli level scope: core Issues happened a the ./src/core level type: enhancement New feature or request
Projects
Pre-GA Post-GA

Comments

@manekinekko
Copy link
Member

Is your feature request related to a problem? Please describe.
When the swa cli tries to star the api project using the func cli (Azure Functions Core Tools). If func is not available, this would trigger an error, an the api won't be emulated.

Describe the solution you'd like
Check if the func cli is already installed. If not, show a warning message or abort the whole process.

Additional context
This should work across all supported platforms.

cc @anthonychu
@manekinekko manekinekko added type: enhancement New feature or request priority: high (P0) High priority scope: core Issues happened a the ./src/core level scope: api Issues related to the user's application API scope: cli Issues happened a the ./src/cli level labels Dec 5, 2020
@manekinekko manekinekko added this to To do in Pre-GA via automation Dec 5, 2020
@manekinekko manekinekko added this to To do in Post-GA Jan 22, 2021
manekinekko added a commit that referenced this issue Feb 7, 2021
@manekinekko
fix: check if func binaries exist before starting
595ae5d 
Closes #38
@manekinekko manekinekko mentioned this issue Feb 7, 2021
Closed
@manekinekko manekinekko moved this from To do to In progress in Pre-GA Feb 16, 2021
@manekinekko manekinekko self-assigned this Feb 27, 2021
Pre-GA automation moved this from In progress to Done Mar 1, 2021
Post-GA automation moved this from To do to Done Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manekinekko manekinekko

Labels
priority: high (P0) High priority scope: api Issues related to the user's application API scope: cli Issues happened a the ./src/cli level scope: core Issues happened a the ./src/core level type: enhancement New feature or request
Projects
Post-GA
Done
Pre-GA
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check if func binaries exist before starting Azure/static-web-apps-cli
1 participant
@manekinekko