Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--api flag not respected in Windows Powershell terminal #88

Closed
nturinski opened this issue Feb 19, 2021 · 6 comments
Closed

--api flag not respected in Windows Powershell terminal #88

nturinski opened this issue Feb 19, 2021 · 6 comments
Labels
os: windows Issues happened on a Windows environment (not WSL). priority: high (P0) High priority scope: cli Issues happened a the ./src/cli level type: bug Something isn't working
Projects

Comments

@nturinski
Copy link

nturinski commented Feb 19, 2021

Describe the bug
Whenever I run swa start .\frontend\build --api .\api from the root of this repo https://github.com/microsoft/vscode-azureappservice/issues, it echoes No API found. Skipping. I've confirmed that this works on MacOS and I have Func Core CLI tools v3.0.3284 installed

To Reproduce
Steps to reproduce the behavior:

  1. Clone and npm install/npm build project https://github.com/microsoft/vscode-azureappservice/issues
  2. From root, run command swa start .\frontend\build --api .\api
  3. API not found error

Expected behavior
For the API folder to be recognized and start running the func core tools

Desktop (please complete the following information):

  • OS: Windows 10 Pro
@manekinekko
Copy link
Member

Thank you @nturinski for opening this issue. @aaronpowell is already looking at this.

@manekinekko manekinekko added priority: high (P0) High priority scope: cli Issues happened a the ./src/cli level type: bug Something isn't working labels Feb 23, 2021
@manekinekko manekinekko added this to To do in Pre-GA via automation Feb 23, 2021
@aaronpowell
Copy link
Contributor

This should be fixed with #71, specifically b5b935b

@manekinekko manekinekko added the os: windows Issues happened on a Windows environment (not WSL). label Mar 1, 2021
@manekinekko manekinekko moved this from To do to Done in Pre-GA Mar 9, 2021
@manekinekko manekinekko moved this from Done to To do in Pre-GA Mar 9, 2021
@itpropro
Copy link

This can be closed, as I have no problems with Windows Terminal 1.5 running PowerShell 7.1 on Windows 10 x64. I use the following syntax and it works fine:

swa start http://localhost:3000 --api http://localhost:7071

image

You can also add --app for the first parameter, but as it's the default one, this works just as expected.

@manekinekko
Copy link
Member

Thank you for the feedback @itpropro !

@nturinski would you mind trying running the CLI from the main branch? we've made some recent changes that might have fixed your issue.

@nturinski
Copy link
Author

I can confirm that this is working! Thanks for all the hard work

image

One thing that's missing from the stable release though is the app alerting you to where it is available, which I thought was a useful touch.

image

@manekinekko
Copy link
Member

Thank you @nturinski for the feedback. We have a whole user story for logging information to the console. I will make sure we add your feedback.

I am going to close this issue (fix landed in main).

Pre-GA automation moved this from To do to Done Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: windows Issues happened on a Windows environment (not WSL). priority: high (P0) High priority scope: cli Issues happened a the ./src/cli level type: bug Something isn't working
Projects
No open projects
Pre-GA
  
Done
Development

No branches or pull requests

4 participants