Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebApp action continues when appname-slotname mismatches SCM credentials #6

Closed
Hazhzeng opened this issue Dec 3, 2019 · 1 comment
Closed

WebApp action continues when appname-slotname mismatches SCM credentials #6

Hazhzeng opened this issue Dec 3, 2019 · 1 comment
Assignees
@N-Usha
Labels
enhancement New feature or request
Projects
GitHub Actions for Azure

Comments

@Hazhzeng
Copy link

Hazhzeng commented Dec 3, 2019 •
edited
Loading

The slot-name setting will be ignored when deploying using SCM credentials.
Since the SCM credential only have access to either production/slot site, we cannot derived web app slot from the product site SCM credentials.

When SCM credential is used, I would recommend concatenating appname-slotname as sitename, and perform a validation against SCM credentals' destinationAppUrl.

This issue is also related to Azure/functions-action#25
@Hazhzeng Hazhzeng mentioned this issue Dec 3, 2019
Merged
@Hazhzeng Hazhzeng changed the title Using SCM credentials will ignore slot-name WebApp action continues when appname-slotname mismatches SCM credentials Dec 3, 2019
@N-Usha N-Usha added this to To be Triaged in GitHub Actions for Azure Feb 27, 2020
@eaarora-ms eaarora-ms added the enhancement New feature or request label May 14, 2020
@github-actions
Copy link

github-actions bot commented Apr 6, 2021

This issue is stale because it has been open for 14 days with no activity. Please remove the stale label or comment on the issue otherwise this will be closed in 5 days

@github-actions github-actions bot added the stale label Apr 6, 2021
GitHub Actions for Azure automation moved this from To be Triaged to Done/Closed Apr 11, 2021
@kaverma kaverma removed the stale label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@N-Usha N-Usha

Labels
enhancement New feature or request
Projects
GitHub Actions for Azure
  
Done/Closed
Milestone
No milestone
Development

No branches or pull requests
4 participants
@N-Usha @kaverma @Hazhzeng @eaarora-ms