Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Protect Authentication Screen #1575

Open
aldsdelram opened this issue Dec 9, 2020 · 1 comment
Open

Request to Protect Authentication Screen #1575

aldsdelram opened this issue Dec 9, 2020 · 1 comment
Assignees
Labels
Enhancement This is a feature request to add functionality that is not currently supported Issue Triage The engineering team has looked into the issue, understood the issue, labelled/classified the issue

Comments

@aldsdelram
Copy link

Hi,

Our application uses this plugin, and is getting flagged when scanned in data theorem. There is a finding wherein we need to protect the app screen from 3rd Party Apps.

These are additional information from data theorem:

  • The following classes in the affected component are currently exposed: com.microsoft.aad.adal.AuthenticationActivity
  • Recommendation is:
    • Protect all sensitive windows within the App by enabling the FLAG_SECURE flag. This flag will prevent Apps from being able to record the protected windows. Also, the flag will prevent users from taking screenshots of these windows (by pressing the VOLUME_DOWN and POWER buttons). As such screenshots are stored on the SDCard by default, they are accessible to all Apps and sensitive data may be exposed.
  • snippet of the code
// Secure code for protecting one Activity
public class SecureActivity extends Activity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        
        // Set the Secure flag for this Window
        getWindow().setFlags(LayoutParams.FLAG_SECURE, LayoutParams.FLAG_SECURE);
    }
}

I hope you could help us regarding this and, if this is possible, we would like to request the recommended fix to be applied to the version 1 of your plugin.

Thank you!

@iambmelt iambmelt added Enhancement This is a feature request to add functionality that is not currently supported Issue Triage The engineering team has looked into the issue, understood the issue, labelled/classified the issue labels Dec 9, 2020
@iambmelt
Copy link
Member

iambmelt commented Dec 9, 2020

@hamiltonha Assigning to you, as this is a feature request. IMO, this looks like a good compliance item to take-on, though I would recommend we do a little design work around how we support it, as screenshots/recordings are often used by our support team to toubleshoot and demonstrate issue repros

@aldsdelram Thanks for filing this request, updates will be provided in this ticket. We are no longer support 2.x.x and 1.x.x versions of ADAL, so this enhancement would ship in a future release of 3.1.x+ if implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This is a feature request to add functionality that is not currently supported Issue Triage The engineering team has looked into the issue, understood the issue, labelled/classified the issue
Projects
None yet
Development

No branches or pull requests

3 participants