Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add czech holidays #26

Merged
merged 7 commits into from May 6, 2016
Merged

Add czech holidays #26

merged 7 commits into from May 6, 2016

Conversation

dfridrich
Copy link
Contributor

No description provided.

@stelgenhof stelgenhof added this to the v1.4.0 milestone May 4, 2016
*
* Class CzechRepublic
* @package Yasumi\Provider
* @author Dennis Fridrich <fridrich.dennis@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you have copied the Germany Test classes :) No problem,but maybe good to remove/adjust all references to the other class and authors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stelgenhof you are right, I recycled Germany version :) Files are repaired now.

@stelgenhof
Copy link
Member

Thanks for the Czech Republic Holiday Provider! Let me have a look at your PR; I'd like to have it then part of the 1.4.0 version.

@stelgenhof
Copy link
Member

Hi @dfridrich
The PR is looking good, but there are some conflicts. Likely because there were some changes to the master branch after your PR. Could you check these please? Then afterwards I will merge your PR!

@dfridrich
Copy link
Contributor Author

@stelgenhof Conflicts are resolved

@stelgenhof stelgenhof merged commit 64a985f into azuyalabs:master May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants