Update Yasumi::getProviders for platform agnosticism #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super! Was thinking about the same, but didn't have the time yet to test on Windows. My understanding is that DIRECTORY_SEPARATOR is not necessarily needed because PHP always converts |
|
This is what getProviders was returning on Windows: |
|
Hmm. I see... |
|
I tried on Windows and see also the 'Unix' style separators but didn't have any issues. Do you encounter any problems because of this? |
|
No problems in usage. Only that the test failed because getProviders was returning full filepaths instead of provider names. |
|
I didn't run the tests. Let me check again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while running tests on #29, Yasumi::getProviders does not work as expected on Windows!
This commit updates Yasumi::getProviders so that instead of hardcoding the unix-style / it instead listens for whatever PHP specifies as the DIRECTORY_SEPARATOR.