Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use create-jest-runner #7

Merged
merged 2 commits into from
Sep 16, 2018
Merged

feat: use create-jest-runner #7

merged 2 commits into from
Sep 16, 2018

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Sep 15, 2018

This simplifies the code a great deal.

create-jest-runner also contains helpers for the boilerplate around creating test results, but I didn't do anything with them for now.


I have high hopes that if we get this module to be smooth people can use it to typecheck and transile their code, and use Babel for Jest (and maybe https://github.com/rickhanlonii/jest-runner-babel for transpiling, leaving this module to just do type-checking in the future)

/cc @rogeliog @rickhanlonii

@SimenB
Copy link
Contributor Author

SimenB commented Sep 15, 2018

We'll need to land runner config at some point (jestjs/jest#4278), so people can provide you with the path to their tsconfig file etc.

@azz azz merged commit ac2730f into azz:master Sep 16, 2018
@azz
Copy link
Owner

azz commented Sep 16, 2018

Thanks! That's so much cleaner!

@azz azz mentioned this pull request Sep 16, 2018
@SimenB SimenB deleted the cjr branch September 16, 2018 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants